Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tensorflow 2.5 through 2.8. #72

Merged
merged 1 commit into from
May 24, 2022
Merged

Support tensorflow 2.5 through 2.8. #72

merged 1 commit into from
May 24, 2022

Conversation

jesnie
Copy link
Collaborator

@jesnie jesnie commented May 17, 2022

  1. Dropped support for Python 3.6.
  2. Added Python 3.9 and 3.10.
  3. Added TensorFlow 2.6, 2.7 and 2.8.
  4. Updated github actions to test all of these combinations.
  5. Had to update some of the tests_requirements - this caused some reformatting.
  6. tfp.Distributions are sometimes wrapped in a _TensorCoercible - I added unwrap_dist to handle this.
  7. For some versions there are problems serialising gpflow.Parameters. I skip the relevant tests.
  8. Apparently the tags that are exported by TensorBoard changes slightly with version. Did a version test for that.
  9. Had to down-adjust coverage to 96% - presumably related to the skipped tests above.

Notice the changes to the build system will require you/us to update the settings on which tests are required to merge.

@jesnie jesnie requested a review from vdutor May 18, 2022 07:56
.github/workflows/quality-check.yaml Outdated Show resolved Hide resolved
.github/workflows/quality-check.yaml Outdated Show resolved Hide resolved
gpflux/types.py Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
@vdutor
Copy link
Member

vdutor commented May 20, 2022

Before you will be able to merge I need to disable the old quality check tests (Python-3.6 tensorflow~=2.5.0, Python-3.7 tensorflow~=2.5.0, Python-3.8 tensorflow~=2.5.0) and enable the new ones. Let me know when you want this to be done.

@jesnie jesnie force-pushed the jesper/tf28 branch 2 times, most recently from 54dd4a1 to ad2a773 Compare May 23, 2022 09:13
@jesnie jesnie merged commit 02268eb into develop May 24, 2022
@jesnie jesnie deleted the jesper/tf28 branch May 24, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants